Skip to content

test(DEVoterVoting): add test for zero duration voting start #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
+18 −11
Merged

test(DEVoterVoting): add test for zero duration voting start #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions test/DEVoterVoting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,7 @@ import { getAddress } from "viem";
import "@nomicfoundation/hardhat-viem";
import "@nomicfoundation/hardhat-viem/types";

// Add type declaration for HardhatRuntimeEnvironment
declare module "hardhat/types" {
interface HardhatRuntimeEnvironment {
viem: {
getWalletClients: () => Promise<any[]>;
deployContract: (name: string, args: any[]) => Promise<any>;
getPublicClient: () => Promise<any>;
};
}
}
// No need for manual type declaration as it's provided by @nomicfoundation/hardhat-viem

describe("DEVoterVoting", function () {
async function deployDEVoterVotingFixture() {
Expand Down Expand Up @@ -98,6 +89,22 @@ describe("DEVoterVoting", function () {
// Allow for a small margin of error due to block time variations
expect(Number(votingStartTime)).to.be.closeTo(startTimeBefore, 5);
});

it("Should reject start with zero duration", async function () {
const { devoterVoting, owner } = await loadFixture(
deployDEVoterVotingFixture
);

// Try to start a voting period with zero duration
await expect(
devoterVoting.write.startVotingPeriod([BigInt(0)], {
account: owner.account,
})
).to.be.rejectedWith("Invalid duration");

// Verify voting period is still inactive
expect(await devoterVoting.read.isVotingActive()).to.be.false;
});
});

describe("endVotingPeriod() tests", function () {
Expand All @@ -120,7 +127,7 @@ describe("DEVoterVoting", function () {


// End the voting period
await devoterVoting.write.endVotingPeriod({
await devoterVoting.write.endVotingPeriod([], {
account: owner.account,
});

Expand Down