Ignore cache directory and target-* files #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanquake
reviewed
Mar 6, 2019
| @@ -13,3 +13,5 @@ target-bin/bootstrap-fixup | |||
| .vagrant | |||
| docker | |||
| *.Dockerfile | |||
| cache | |||
| target-* | |||
There was a problem hiding this comment.
@fanquake
It creates (particularly using LXC) two files:
gitian-builder/bin/make-base-vm
Line 117 in 4053f3c
gitian-builder/libexec/make-clean-vm
Line 57 in 3934150
base-bionic-amd64 and target-bionic-amd64.
The former is ignored already:
Line 9 in 27d0130
The latter (target-* or target*) should be ignored too.
devrandom
approved these changes
Mar 9, 2019
devrandom
added a commit
that referenced
this pull request
Mar 9, 2019
4eda053 Ignore cache directory and target-* files (Hennadii Stepanov)
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 20, 2020
Summary: This fixes an issue introduced by devrandom/gitian-builder#206. The `target-*` pattern not only matches the target image name but also the `target-bin` directory which contains useful files. This allows for adding the missing files as well. Depends on D6972. Test Plan: NOP() Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6973
melroy89
pushed a commit
to BitcoinCash1/Bitcoin-Cash-Node
that referenced
this pull request
Oct 10, 2024
Summary: This fixes an issue introduced by devrandom/gitian-builder#206. The `target-*` pattern not only matches the target image name but also the `target-bin` directory which contains useful files. This allows for adding the missing files as well. Depends on D6972. Test Plan: NOP() Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.