Skip to content

ISS-183379: Update hybrid mobile SDK docs with sample app section(React Native, Expo, Cordova) #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 18, 2025

Conversation

dhananjayj-dev
Copy link
Contributor

@dhananjayj-dev dhananjayj-dev commented Jun 16, 2025

Description ✏️

This PR updates the public documentation for our hybrid SDKs to reflect the latest changes in the sample applications.

Important

Check the Hide whitespace option when reviewing.

Links 📍

/close ISS-183379

AI-assisted work 📈

0%

@dhananjayj-dev dhananjayj-dev requested a review from bc-devrev June 16, 2025 16:53
@dhananjayj-dev dhananjayj-dev self-assigned this Jun 16, 2025
@dhananjayj-dev dhananjayj-dev requested a review from a team as a code owner June 16, 2025 16:53
Copy link
Contributor

github-actions bot commented Jun 16, 2025

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email support@ekline.io.

Copy link
Contributor

Copy link
Contributor

@@ -5,14 +5,14 @@ This guide helps you integrate the DevRev SDK into your Cordova app.
## Requirements

- Cordova CLI 10.0.0 or higher.
- A minimum deployment target of Android 5.0 (API level 21) or iOS 11.
- A minimum deployment target Android SDK 24 or iOS 15.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A minimum deployment target Android SDK 24 or iOS 15.
- Minimum deployment target Android SDK 24 or iOS 15.

@@ -30,3 +30,35 @@ The SDK will be ready for use once you execute the following configuration metho
```javascript
DevRev.configure(appID, successCallback, errorCallback)
```

## Sample app
A sample app with use cases for the DevRev Cordova plugin has been provided as a part of our [public repository](https://github.com/devrev/devrev-sdk-cordova). To set up and run the sample app:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A sample app with use cases for the DevRev Cordova plugin has been provided as a part of our [public repository](https://github.com/devrev/devrev-sdk-cordova). To set up and run the sample app:
A sample app with use cases for the DevRev Cordova plugin is provided as part of our [public repository](https://github.com/devrev/devrev-sdk-cordova). To set up and run the sample app:

## Sample app
A sample app with use cases for the DevRev Cordova plugin has been provided as a part of our [public repository](https://github.com/devrev/devrev-sdk-cordova). To set up and run the sample app:

```sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what the relationship between these steps and the Android/iOS-specific steps below are.

Tabs are often used for platform-specific information. https://buildwithfern.com/learn/docs/content/components/tabs

Comment on lines 29 to 30
```sh
cd sample
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the codeblocks as in the preceding section.

Suggested change
```sh
cd sample
```sh
cd sample

Comment on lines 37 to 45
3. For iOS, run:
```sh
cd ios
pod install
```

Then, open DevRevSDKSample.xcworkspace in Xcode and run the app.

4. Run the app on Android or iOS using:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sequence is unclear here. The Xcode step should be numbered.

Copy link
Contributor

Copy link
Contributor

@dhananjayj-dev dhananjayj-dev requested a review from bc-devrev June 16, 2025 17:59
Copy link
Contributor

@dhananjayj-dev dhananjayj-dev merged commit 936a677 into main Jun 18, 2025
6 checks passed
@dhananjayj-dev dhananjayj-dev deleted the feature/ISS-183379-update-hybrid-docs-samples branch June 18, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants