Skip to content

PLuG user identification docs improvements #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 24, 2025

Conversation

kunal-mohta-99
Copy link
Contributor

@kunal-mohta-99 kunal-mohta-99 commented Jul 15, 2025

Summary

This change improves the PLuG Web SDK's user identification documentation by adding a visual graphic and a new section for "Changing the user identity" which adds some frequently used code snippets.

Connected Issues

https://app.devrev.ai/devrev/works/ISS-192528

Craftsmanship, Integrity, and Devil’s Advocacy

  • Testing: Negative test cases: null or default values, crash and fault injection tests
  • Testing: Boundary conditions: rolling upgrades, denial-of-service, etc.
  • Testing: Fixing a few existing — flaky or permanently-broken — test cases
  • Observing: Detailed error codes so machines can understand
  • Observing: Adding superior metrics for future debugging
  • Observing: Tracing the hairiest pathways for field serviceability
  • Training: KnowledgeOps update? So AI always works.

Story of the craft

@kunal-mohta-99 kunal-mohta-99 requested a review from a team as a code owner July 15, 2025 17:45
Copy link
Contributor

github-actions bot commented Jul 15, 2025

🌟 EkLine Reviewer

Hello! I’m here to help improve your docs. I’ve reviewed your pull request, and left in-line suggestions for quick fixes. For details, visit the Analytics Page.

For questions or feedback, please email support@ekline.io.

Copy link
Contributor

Copy link
Contributor

@bc-devrev bc-devrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identity: {},
});
```
<Callout intent="note">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too much for a callout. A section would be a more suitable container.

Copy link
Contributor

Copy link
Contributor

This reverts commit 5af9512.
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@bc-devrev bc-devrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple comments.


In most cases, this works as expected—user identification typically happens after login or signup, which causes a page reload and clears any previous PLuG instance.

However, if your application needs to update the user identity without a full page refresh, you'll need to explicitly delete the existing PLuG instance before initializing it again with the new user information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Contributor

Atul-Butola and others added 2 commits July 24, 2025 15:28
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Colborn <ben.colborn@devrev.ai>
Copy link
Contributor

identity: {},
});
```
If you're using the PLuG SDK for recording user sessions, calling the `shutdown()` method will stop the ongoing session recording. Re-initializing with the `init()` method will then start a new session recording. To avoid losing continuity, you can pass the details of the ongoing session recording when re-initializing PLuG.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [EkLine]

Suggestions:

    Where possible, do not structure sentences in future tense. Use present tense instead. (EK00005)

Suggested change
If you're using the PLuG SDK for recording user sessions, calling the `shutdown()` method will stop the ongoing session recording. Re-initializing with the `init()` method will then start a new session recording. To avoid losing continuity, you can pass the details of the ongoing session recording when re-initializing PLuG.
If you're using the PLuG SDK for recording user sessions, calling the `shutdown()` method stops the ongoing session recording. Re-initializing with the `init()` method then starts a new session recording. To avoid losing continuity, you can pass the details of the ongoing session recording when re-initializing PLuG.

Copy link
Contributor

@Atul-Butola Atul-Butola merged commit 529cce0 into main Jul 24, 2025
6 checks passed
@Atul-Butola Atul-Butola deleted the chore/update-web-user-identification branch July 24, 2025 10:56
tilenkavcic pushed a commit that referenced this pull request Jul 25, 2025
* PLuG user identification docs improvements

* address review comments

* diagram font

* Revert "diagram font"

This reverts commit 5af9512.

* diagram font

* Update fern/docs/pages/sdks/web/user-identity.mdx

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update fern/docs/pages/sdks/web/user-identity.mdx

Co-authored-by: Ben Colborn <ben.colborn@devrev.ai>

* update font

---------

Co-authored-by: Ben Colborn <ben.colborn@devrev.ai>
Co-authored-by: Atul-Butola <atul.butola@devrev.ai>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tilenkavcic added a commit that referenced this pull request Jul 28, 2025
* Update MCP files description

* Remove reference to by field

* Update proguard troubleshooting guide (#281)

* PLuG user identification docs improvements (#279)

* PLuG user identification docs improvements

* address review comments

* diagram font

* Revert "diagram font"

This reverts commit 5af9512.

* diagram font

* Update fern/docs/pages/sdks/web/user-identity.mdx

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update fern/docs/pages/sdks/web/user-identity.mdx

Co-authored-by: Ben Colborn <ben.colborn@devrev.ai>

* update font

---------

Co-authored-by: Ben Colborn <ben.colborn@devrev.ai>
Co-authored-by: Atul-Butola <atul.butola@devrev.ai>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore: update session ingestion URLs (#282)

* Nit

* Nit

* Update fern/docs/pages/airdrop/mcp.mdx

---------

Co-authored-by: Rohan Gupta <rohan.gupta@devrev.ai>
Co-authored-by: Kunal Mohta <kunal.mohta@devrev.ai>
Co-authored-by: Ben Colborn <ben.colborn@devrev.ai>
Co-authored-by: Atul-Butola <atul.butola@devrev.ai>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants