V4 - First attempt #415
V4 - First attempt #415
Conversation
| }, 600); | ||
| } | ||
|
|
||
| if (environment?.production === false) { |
There was a problem hiding this comment.
I do not like env. depending configs. Feature toggles are better.
From my point of view, we should fetch this info during build. We can share the work: I add a yaml file with the info and you add it?
There was a problem hiding this comment.
We can have the version information available at the about page?
| assessment: activity.assessment.toString() || '', | ||
| level: activity.level || 0, | ||
| teamImplementation: activity.implementation || {}, | ||
| // teamsEvidence: activity.teamsEvidence || {}, |
There was a problem hiding this comment.
is there a reason to not have teamsEvidence?
| @@ -0,0 +1,8597 @@ | |||
| --- | |||
There was a problem hiding this comment.
The generated.yaml should not be part of this repo because it is generated in the -data repo
| fetch( | ||
| 'https://api.github.com/repos/devsecopsmaturitymodel/DevSecOps-MaturityModel/branches/v4' | ||
| ).then(async response => { | ||
| let gitinfo: any = await response.json(); | ||
| let commitDate: string = gitinfo?.commit?.commit?.author?.date; | ||
| if (commitDate) { | ||
| this.subtitle = `Released: ${commitDate?.replace('T', ' ')}`; | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Could we add a retry mechanism to the fetch function in case something goes wrong?
| activityName="{{ | ||
| currentActivity.activityName | ||
| }}"></app-dependency-graph> | ||
| <div *ngIf="currentActivity && currentActivity.name"> |
There was a problem hiding this comment.
Can't we replace this with just currentActivity?.name
Centralized data loader. New Teams page. Massive refactoring.
Great work from @vbakke