Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading and displaying current song's lyrics #478

Open
yonailo opened this issue Sep 16, 2014 · 5 comments
Open

Downloading and displaying current song's lyrics #478

yonailo opened this issue Sep 16, 2014 · 5 comments
Labels

Comments

@yonailo
Copy link

yonailo commented Sep 16, 2014

Hi,

Keep up the hard work guys, congratulations I am very happy since I have discovered your project.

I would like to propose a new feature. I am a big fan of lyrics, I mean they help me better understand the songs. It is a big big feature for me.

Wouldn't it be possible to download & display the lyrics of the current song at the left side pane ? I see that downloading artworks is already in place (and works very well), so the downloading of lyrics would not be so difficult...

Thank you.

@devsnd
Copy link
Owner

devsnd commented Sep 17, 2014

Hello Yanailo,

Thanks for you suggestion; It Indeed is possible to implement this feature, but right now both me and @tilboerner are quite busy and can only make the occasional fix for CM. 🚌

If you really want to see this feature done, I'd urge you to do the research for us needed to get it done:
Compare different web services where many song lyrics are available. This is very important, since we don't want CM only to show lyrics of Britney Spears, but also some lesser known music. The best service might even offer an API (ready made access for other programs, like CM), which would be best. Also, If there is no API, and if you know some HTML, you might want to make sure that the site is properly structured, so we can easily grab the lyrics from it. Once you've compared different services, you can then show us the advantages and disadvantages of each of them and we'll write some code to try it out.

It's up to you! 🎉

@yonailo
Copy link
Author

yonailo commented Oct 22, 2014

Hello,

I had got your message into SPAM sorry for my late answer.

I will take into account your suggestions, the problem is that I dont have
very much spare time either. It is true that the best thing to do would be
to have an API, if we can not find a lyric's site with a propre API I think
it is not worth doing this.

I will come back to you if I find something. thank you very much.

On Wed, Sep 17, 2014 at 10:50 AM, Tom Wallroth notifications@github.com
wrote:

Hello Yanailo,

Thanks for you suggestion; It Indeed is possible to implement this
feature, but right now both me and @tilboerner
https://github.com/tilboerner are quite busy and can only make the
occasional fix for CM. [image: 🚌]

If you really want to see this feature done, I'd urge you to do the
research for us needed to get it done:
Compare different web services where many song lyrics are available. This
is very important, since we don't want CM only to show lyrics of Britney
Spears, but also some lesser known music. The best service might even offer
an API (ready made access for other programs, like CM), which would be
best. Also, If there is no API, and if you know some HTML, you might want
to make sure that the site is properly structured, so we can easily grab
the lyrics from it. Once you've compared different services, you can then
show us the advantages and disadvantages of each of them and we'll write
some code to try it out.

It's up to you! [image: 🎉]


Reply to this email directly or view it on GitHub
#478 (comment).

@MrRKernelPanic
Copy link

Dear All,

I too think this would be a great feature or perhaps use one already available, web based and maintained by someone else: What about the Lyrics By Rob plugin for Chrome / Firefox etc.

I approached him if he would be willing to consider adding support for Cherry Music and he sent this lovely Email back. I just wish I was clever enough to know the answers to any of these questions:


Hi Mark,

I'm open to supporting CherryMusic. In order to recognize and support the site, I need to know the answers to a few questions:

  • Which URLs belong to the website? (CherryMusic seems self-hosted, which could be an issue for a one-size-fits-all solution. If the domain is not ://localhost:/, then I probably have to add an option to set the CM domain in the preferences).
  • Which artist + song is being played? E.g. is there a fixed place in the document that displays the song + artist name?
  • How do I know when a new song is played? (if unknown, I just poll the document a few times per second. If known, then I can use the knowledge to optimize the detection of songs).
  • Where should the panel be displayed? Until now, the lyrics was always shown as a floating panel within the page. I have refactored the code a little bit, and in the next version it is also possible to put the lyrics in a fixed location within the document, or even detach the panel and have it in its own window, see attached screenshot.
  • When the panel is closed or hidden, where should the tiny button be put?
  • How do I automatically test whether the integration of my extension and the site still works as expected? So far, every site I'm supporting is online, so it's a matter of loading the extension, visiting the site and verifying whether the extension behaves as expected (using Selenium).

CM is open-source, so if there is no easy way to address any of the previous questions, then you could send a pull request to the Github repo, and have your answer ready :)

Once the answers are known, supporting the site is very straightforward. I plan on publishing an update very soon, so if you get back within a week or so, then the next update could contain CM support.

Kind regards,
Rob
https://robwu.nl

@yonailo
Copy link
Author

yonailo commented Feb 19, 2017

Maybe a simpler option would be to read srt files like is done with movies?

@yonailo
Copy link
Author

yonailo commented Feb 19, 2017

Or better read USLT Id3 tags (Unsynchronized lyric/text Transcription) directly from thé music file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants