feat: add helm generic plugin #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronCore864
requested changes
Apr 28, 2022
|
Also, please try to avoid duplicated commit messages. Try to use meaningful ones for all commits.
|
lfbdev
force-pushed
the
feat-helm-generic
branch
from
90c4519 to
6129497
Compare
daniel-hutao
requested changes
Apr 29, 2022
daniel-hutao
requested changes
Apr 30, 2022
| # whether to wait for the release to be deployed or not | ||
| wait: true | ||
| # the time to wait for any individual Kubernetes operation (like Jobs for hooks). This defaults to 5m0s | ||
| timeout: 5m | ||
| # whether to perform a CRD upgrade during installation | ||
| upgradeCRDs: true | ||
| # custom configuration (Optional). You can refer to [ArgoCD values.yaml](https://github.com/argoproj/argo-helm/blob/master/charts/argo-cd/values.yaml) | ||
| # custom configuration (Optional). e.g. You can refer to [ArgoCD values.yaml](https://github.com/argoproj/argo-helm/blob/master/charts/argo-cd/values.yaml) | ||
| values_yaml: | | ||
| controller: |
There was a problem hiding this comment.
controller: xxx is used for ArgoCD. Maybe we can leave FOO: BAR here.
|
It seems values_yaml doesn't work. Config: tools:
- name: helm-generic
instanceID: nginx
options:
create_namespace: true
repo:
name: bitnami
url: https://charts.bitnami.com/bitnami
chart:
chart_name: bitnami/nginx
release_name: my-nginx
namespace: nginx
wait: true
timeout: 5m
values_yaml: |
replicaCount: 2
service:
type: ClusterIP |
IronCore864
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add a new plugin for helm-type plugin install
Description
see the proposal #424
Related Issues
#424
Current Behavior