Skip to content

Conversation

shubham-cmyk
Copy link

@shubham-cmyk shubham-cmyk commented Jun 1, 2022

Pre-Checklist

Description

style : Change Symbol Type of logging levels

Debug and Error were having same symbol type so updating it that makes more differentiating and more appealing.
Symbol of Debug and Info was ( i ) also Error and Fatal was ( x ) so making Debug to ( λ ) and Error to ( !! )

Related Issues

#646

Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-hutao
Copy link
Member

@shubham-cmyk Thanks for the pr. And please note the commit message format.

@shubham-cmyk
Copy link
Author

@daniel-hutao Thanks!

@iyear
Copy link
Member

iyear commented Jun 2, 2022

@shubham-cmyk
If you are using goland, you can select the local branch commit, modify the message, and then run git push -f in the terminal to modify the remote commit message.

You can also use the command line to modify the historical commit message, but it's a little more complicated.

@IronCore864 IronCore864 merged commit aa6765b into devstream-io:main Jun 6, 2022
@aFlyBird0
Copy link
Member

@shubham-cmyk Here's a little trick that might help you, use close #646 to automatically close the issue when the PR is merged.

@daniel-hutao #646 is resolved, please close it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants