Skip to content

Conversation

galarao
Copy link

@galarao galarao commented Jun 9, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

New Behavior (screenshots if needed)

@galarao galarao requested a review from a team as a code owner June 9, 2022 02:25
@daniel-hutao
Copy link
Member

@rxhuster Good job!
Please contact me on WeChat and I will prepare a certificate and some gifts for you.


I've tested this pr locally. Everything does well.


close #660

@daniel-hutao
Copy link
Member

I'd like to merge it now.

@daniel-hutao daniel-hutao merged commit 27a3d52 into devstream-io:main Jun 9, 2022
@summingyu
Copy link

You can look at this https://github.com/conventional-changelog/commitlint/#what-is-commitlint , welcome to the next pr

Copy link

@summingyu summingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants