Skip to content

Conversation

LauraJW
Copy link

@LauraJW LauraJW commented Jul 14, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

Related Issues

close #724

New Behavior (screenshots if needed)

@LauraJW LauraJW requested a review from IronCore864 as a code owner July 14, 2022 11:09
@steinliber
Copy link

A kind reminder that you haven't signed off on your commit(s) yet. Check out our official doc to learn how to do this.

Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that this document does not correspond exactly to the English version. Please check the latest English version of the document and update it, thanks!

https://docs.devstream.io/en/latest/core-concepts/core-concepts/

Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0
Copy link
Member

Hi @LauraJW , thanks for your contribution! Please join CNCF's Slack, and join our channel in CNCF Slack!

Here are a few useful things for you to continue your open-source journey:

We made changes to your PR directly so that your contribution can be merged quicker. We hope you don't mind!

A kind reminder that you haven't signed off on your commit(s) yet. Check out our official doc to learn how to do this. Also, DevStream community follows the conventional commits specification. Please read our doc and update your commit message.

@aFlyBird0 aFlyBird0 removed their assignment Jul 16, 2022
@aFlyBird0 aFlyBird0 requested a review from daniel-hutao July 16, 2022 10:15
@aFlyBird0 aFlyBird0 merged commit 194f217 into devstream-io:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📖 Docs(Translation): Tool, State, and Resource - Chinese Version
5 participants