refactor: configloader -> configmanager #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-hutao
force-pushed
the
refactor-1
branch
from
1b26760 to
add2cfd
Compare
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
changed the title
…anager package Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
force-pushed
the
refactor-1
branch
from
eb616c2 to
7b15477
Compare
daniel-hutao
changed the title
iyear
approved these changes
Aug 9, 2022
IronCore864
approved these changes
Aug 9, 2022
aFlyBird0
requested changes
Aug 9, 2022
|
More OOP, cool! |
aFlyBird0
approved these changes
Aug 9, 2022
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Hu tao.hu@merico.dev
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
We've changed
config loadertoconfig managerin the docs, e.g.: https://docs.devstream.io/en/release-0.8/core-concepts/core-concepts/So I refactored the code too.
Related Issues
N/A
New Behavior (screenshots if needed)
N/A