Skip to content

fix: useless if statement #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2022
Merged

fix: useless if statement #985

merged 2 commits into from
Aug 11, 2022

Conversation

iyear
Copy link
Member

@iyear iyear commented Aug 11, 2022

Signed-off-by: iyear ljyngup@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

see #973 (comment) for details

@iyear
fix: useless if statement
4ba65da 
Signed-off-by: iyear <ljyngup@gmail.com>
@iyear iyear requested a review from a team as a code owner August 11, 2022 05:00
@iyear
Copy link
Member Author

iyear commented Aug 11, 2022 •
edited
Loading

go-github thinks the http status code is err=nil between 200 and 299, and the RFC also specifies this.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status

I will fix the corresponding test files.

@iyear
fix: github test files
2b77287 
Signed-off-by: iyear <ljyngup@gmail.com>
@steinliber steinliber merged commit fbc9444 into devstream-io:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steinliber steinliber steinliber approved these changes

@aFlyBird0 aFlyBird0 aFlyBird0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iyear @steinliber @aFlyBird0