fix: updated ValidateRegistryStorageType for OCI registry configs (#3634

)
devtron-labs · Jul 14, 2023 · 9cc90fb · 9cc90fb
1 parent 373e784
commit 9cc90fb
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/pkg/pipeline/DockerRegistryConfig.go b/pkg/pipeline/DockerRegistryConfig.go
@@ -132,14 +132,18 @@ Returns:
 */
 func (impl DockerRegistryConfigImpl) ValidateRegistryStorageType(registryId string, storageType string, storageActions ...string) bool {
 	isValid := false
-	ociRegistryConfigList, err := impl.ociRegistryConfigRepository.FindByDockerRegistryId(registryId)
+	store, err := impl.dockerArtifactStoreRepository.FindOne(registryId)
 	if err != nil {
 		return false
 	}
-	for _, ociRegistryConfig := range ociRegistryConfigList {
-		if ociRegistryConfig.RepositoryType == storageType && slices.Contains(storageActions, ociRegistryConfig.RepositoryAction) {
-			isValid = true
+	if store.IsOCICompliantRegistry {
+		for _, ociRegistryConfig := range store.OCIRegistryConfig {
+			if ociRegistryConfig.RepositoryType == storageType && slices.Contains(storageActions, ociRegistryConfig.RepositoryAction) {
+				isValid = true
+			}
 		}
+	} else {
+		return true
 	}
 	return isValid
 }