New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated ValidateRegistryStorageType for OCI registry configs #3634

Merged

Ash-exp merged 1 commit into main from fix-oci-container-registry

Jul 14, 2023

Contributor

Ash-exp commented Jul 14, 2023 •

edited

Description

This PR fixes the CI build config error for container registry for devtron applications.

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


          fix: updated ValidateRegistryStorageType for OCI registry configs

645d1e4

Ash-exp added the enhancement label

Ash-exp requested a review from vikramdevtron

July 14, 2023 06:25

Ash-exp added this to In progress in devtron via automation

Ash-exp self-assigned this

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

vikramdevtron approved these changes

View reviewed changes

devtron automation moved this from In progress to Reviewer approved

Ash-exp merged commit 9cc90fb into main

4 checks passed

devtron automation moved this from Reviewer approved to Done

Ash-exp deleted the fix-oci-container-registry branch

July 14, 2023 06:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment