Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Image tag not propagated in Rollback #3897

Merged
merged 15 commits into from
Sep 14, 2023
Merged

Conversation

adi6859
Copy link
Contributor

@adi6859 adi6859 commented Sep 13, 2023

Description

When you select any image for rollback, image tag is not visible .

Fixes #

How Has This Been Tested?

All tests has been performed locally

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adi6859 adi6859 changed the base branch from main to stable-dt19-v1 September 14, 2023 06:09
Copy link
Member

@gireesh-devtron gireesh-devtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adi6859 adi6859 merged commit cd1be97 into stable-dt19-v1 Sep 14, 2023
4 of 5 checks passed
@adi6859 adi6859 deleted the image-tag-bug branch September 14, 2023 11:47
vikramdevtron added a commit that referenced this pull request Sep 27, 2023
* fix:Image tag not propagated in Rollback (#3897)

* devtronContainerImageRepo varilable added

* bug fixed around image tags and comment

* fix: block trigger for vulnerable image (#3888)

* fix: invalid post deployment status in App group (#3880)

* fixed: updated invalid installed version error message (#3889)

* feat: updated error message for installed app (#3894)

* bug fix (#3903)

* bug fix (#3907)

* fix: Deployment is breaking due to invalid environment name (#3896)

* replace _ with -

* add proper comment

* fix: invalid cluster details fetched for partial delete state (#3898)

* fix: Security scan list fix (#3901)

* bug fix

* sql scripts written

* query updated

* fix

* migration script

* bug fix

* code review comments resolved

* code review comments resolved

* code review comments resolved

* fix: updated previous deployment status (#3939)

* fix: updated delete installed app error (#3941)

* check for update access while updating (#3944)

* fix: workflow not created for auto trigger (#3947)

* fix: helm app delete error (#3949)

---------

Co-authored-by: Aditya Ranjan <91401966+adi6859@users.noreply.github.com>
Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com>
Co-authored-by: ShashwatDadhich <dadhichshashwat1808@gmail.com>
Co-authored-by: Ashish-devtron <123808329+Ashish-devtron@users.noreply.github.com>
Co-authored-by: Vikram Singh <vikram@devtron.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants