-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix #3903
bug fix #3903
Conversation
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -454,6 +454,9 @@ func (impl *K8sApplicationServiceImpl) GetAllApiResourceGVKWithoutAuthorization( | |||
k8sEventIndex = index | |||
} | |||
} | |||
if gvk.Kind == "Node" { | |||
allApiResources = append(allApiResources[:index], allApiResources[index+1:]...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the time complexity of this operation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is linear but the scale pf objects is around 20
* fix:Image tag not propagated in Rollback (#3897) * devtronContainerImageRepo varilable added * bug fixed around image tags and comment * fix: block trigger for vulnerable image (#3888) * fix: invalid post deployment status in App group (#3880) * fixed: updated invalid installed version error message (#3889) * feat: updated error message for installed app (#3894) * bug fix (#3903) * bug fix (#3907) * fix: Deployment is breaking due to invalid environment name (#3896) * replace _ with - * add proper comment * fix: invalid cluster details fetched for partial delete state (#3898) * fix: Security scan list fix (#3901) * bug fix * sql scripts written * query updated * fix * migration script * bug fix * code review comments resolved * code review comments resolved * code review comments resolved * fix: updated previous deployment status (#3939) * fix: updated delete installed app error (#3941) * check for update access while updating (#3944) * fix: workflow not created for auto trigger (#3947) * fix: helm app delete error (#3949) --------- Co-authored-by: Aditya Ranjan <91401966+adi6859@users.noreply.github.com> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com> Co-authored-by: ShashwatDadhich <dadhichshashwat1808@gmail.com> Co-authored-by: Ashish-devtron <123808329+Ashish-devtron@users.noreply.github.com> Co-authored-by: Vikram Singh <vikram@devtron.ai>
Description
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?