Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to edit chart-group with edit access #3944

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

Ashish-devtron
Copy link
Contributor

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@Ashish-devtron Ashish-devtron changed the title Chart group edit permission fix: Unable to edit chart-group with edit access Sep 21, 2023
@Ashish-devtron Ashish-devtron marked this pull request as ready for review September 21, 2023 05:20
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ashish-devtron Ashish-devtron merged commit 0cca0de into stable-dt19-v1 Sep 21, 2023
4 checks passed
@Ashish-devtron Ashish-devtron deleted the chart-group-edit-permission branch September 21, 2023 05:28
vikramdevtron added a commit that referenced this pull request Sep 27, 2023
* fix:Image tag not propagated in Rollback (#3897)

* devtronContainerImageRepo varilable added

* bug fixed around image tags and comment

* fix: block trigger for vulnerable image (#3888)

* fix: invalid post deployment status in App group (#3880)

* fixed: updated invalid installed version error message (#3889)

* feat: updated error message for installed app (#3894)

* bug fix (#3903)

* bug fix (#3907)

* fix: Deployment is breaking due to invalid environment name (#3896)

* replace _ with -

* add proper comment

* fix: invalid cluster details fetched for partial delete state (#3898)

* fix: Security scan list fix (#3901)

* bug fix

* sql scripts written

* query updated

* fix

* migration script

* bug fix

* code review comments resolved

* code review comments resolved

* code review comments resolved

* fix: updated previous deployment status (#3939)

* fix: updated delete installed app error (#3941)

* check for update access while updating (#3944)

* fix: workflow not created for auto trigger (#3947)

* fix: helm app delete error (#3949)

---------

Co-authored-by: Aditya Ranjan <91401966+adi6859@users.noreply.github.com>
Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com>
Co-authored-by: ShashwatDadhich <dadhichshashwat1808@gmail.com>
Co-authored-by: Ashish-devtron <123808329+Ashish-devtron@users.noreply.github.com>
Co-authored-by: Vikram Singh <vikram@devtron.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant