fix: invalid cluster details fetched for partial delete state #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamayushm
approved these changes
Sep 15, 2023
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 141558 | Generic High Entropy Secret | e3b3633 | scripts/devtron-reference-helm-charts/statefulset-chart_5-0-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Kudos, SonarCloud Quality Gate passed!
|
vikramdevtron
approved these changes
Sep 15, 2023
vikramdevtron
added a commit
that referenced
this pull request
Sep 27, 2023
* fix:Image tag not propagated in Rollback (#3897) * devtronContainerImageRepo varilable added * bug fixed around image tags and comment * fix: block trigger for vulnerable image (#3888) * fix: invalid post deployment status in App group (#3880) * fixed: updated invalid installed version error message (#3889) * feat: updated error message for installed app (#3894) * bug fix (#3903) * bug fix (#3907) * fix: Deployment is breaking due to invalid environment name (#3896) * replace _ with - * add proper comment * fix: invalid cluster details fetched for partial delete state (#3898) * fix: Security scan list fix (#3901) * bug fix * sql scripts written * query updated * fix * migration script * bug fix * code review comments resolved * code review comments resolved * code review comments resolved * fix: updated previous deployment status (#3939) * fix: updated delete installed app error (#3941) * check for update access while updating (#3944) * fix: workflow not created for auto trigger (#3947) * fix: helm app delete error (#3949) --------- Co-authored-by: Aditya Ranjan <91401966+adi6859@users.noreply.github.com> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com> Co-authored-by: ShashwatDadhich <dadhichshashwat1808@gmail.com> Co-authored-by: Ashish-devtron <123808329+Ashish-devtron@users.noreply.github.com> Co-authored-by: Vikram Singh <vikram@devtron.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invalid cluster details fetched for the given environment id in partial delete state.
Fixes #
How Has This Been Tested?
Argo CD Devtron App
Argo CD Helm App
Checklist:
Does this PR introduce a user-facing change?