fix: Security scan list fix #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
vikramdevtron
added a commit
that referenced
this pull request
Sep 27, 2023
* fix:Image tag not propagated in Rollback (#3897) * devtronContainerImageRepo varilable added * bug fixed around image tags and comment * fix: block trigger for vulnerable image (#3888) * fix: invalid post deployment status in App group (#3880) * fixed: updated invalid installed version error message (#3889) * feat: updated error message for installed app (#3894) * bug fix (#3903) * bug fix (#3907) * fix: Deployment is breaking due to invalid environment name (#3896) * replace _ with - * add proper comment * fix: invalid cluster details fetched for partial delete state (#3898) * fix: Security scan list fix (#3901) * bug fix * sql scripts written * query updated * fix * migration script * bug fix * code review comments resolved * code review comments resolved * code review comments resolved * fix: updated previous deployment status (#3939) * fix: updated delete installed app error (#3941) * check for update access while updating (#3944) * fix: workflow not created for auto trigger (#3947) * fix: helm app delete error (#3949) --------- Co-authored-by: Aditya Ranjan <91401966+adi6859@users.noreply.github.com> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com> Co-authored-by: ShashwatDadhich <dadhichshashwat1808@gmail.com> Co-authored-by: Ashish-devtron <123808329+Ashish-devtron@users.noreply.github.com> Co-authored-by: Vikram Singh <vikram@devtron.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix For
1: user created a new app with security scan on but all kind of vulnerabilities is allowed .
2: app get deployed , now go to the security section , go to security scan tab , app will be visible there .
3:now i turned off the security scan and again create new image of app and deploy that image with no vulnerability scanning . as scanning was off so in new build no vulnerabilities would be listed .
4: But the security scan tab still the app in the list with timestamp of when it was earlier published with security scan .
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: