Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGC allways "60" after Switch-On #1730

Closed
ghost opened this issue Feb 3, 2019 · 5 comments
Closed

AGC allways "60" after Switch-On #1730

ghost opened this issue Feb 3, 2019 · 5 comments
Labels
bug

Comments

@ghost
Copy link

ghost commented Feb 3, 2019

Your firmware version: 2.11.29
Your bootloader version: 5.0.4

Hardware

SParrow H7 CPU

Issue:
after each switch-on the AGC is set to "60" again, no matter what was previously set!
No matter if SSB, CW or SAM

73!
Thomas
@df8oe
Copy link
Owner

df8oe commented Feb 3, 2019

Thats correct. But I do not know if storing is useful. You have to change the value due to band, time of day etc. so that a stored value matches as rarely or as often as "60" ;) I have not looked into the code so that I am not sure it is a bug or a feature...

@df8oe df8oe added the bug label Feb 3, 2019
@ghost
Copy link
Author

ghost commented Feb 3, 2019

that's right Andreas, but "60" is a little far from the normal setting.
In my setup, the AGC is regular at 10-20.

73
Thomas

@db4ple
Copy link
Collaborator

db4ple commented Feb 3, 2019

AGC is normally saved. I'll check what I broke. I have the same issue but did not notice. Thanks for reporting.

db4ple added a commit to db4ple/UHSDR that referenced this issue Feb 3, 2019
@db4ple
Fix for df8oe#1730 (AGC values are not restored)
29e90e3 
- This fix is necessary, because I changed the order of initiallization
  (first load config values AND AFTER THAT run the initialization using the
   load parameters ) but some code overwrote already loaded config values
   which previously was not visible since this code was executed BEFORE we
   loaded config values...
db4ple added a commit to db4ple/UHSDR that referenced this issue Feb 3, 2019
@db4ple
Fix for df8oe#1730 (AGC values are not restored)
cfbaae7 
- This fix is necessary, because I changed the order of initiallization
  (first load config values AND AFTER THAT run the initialization using the
   load parameters ) but some code overwrote already loaded config values
   which previously was not visible since this code was executed BEFORE we
   loaded config values...
df8oe added a commit that referenced this issue Feb 4, 2019
@df8oe
Merge pull request #1732 from db4ple/audio_driver_breakup
ae95236 
 Fix for #1730 (AGC values are not restored) and type "changes"
@db4ple
Copy link
Collaborator

db4ple commented Feb 4, 2019

Should be fixed now.

@ghost
Copy link
Author

ghost commented Feb 4, 2019

thanks Danilo and Andreas for the quick fix.
I close it later

@ghost ghost closed this as completed Feb 4, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@df8oe @db4ple