Use non-main queue in main actor tests #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 1060 1060
=========================================
Hits 1060 1060
|
dfed
force-pushed
the
dfed--use-global-queue-in-tests
branch
2 times, most recently
from
b1f6644 to
fd5ef69
Compare
dfed
changed the title
dfed
force-pushed
the
dfed--use-global-queue-in-tests
branch
from
fd5ef69 to
ad23040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a theory that occasional CI failures (example 1, example 2) are caused by
MainActorQueueTestsoccasionally running tests onmainthat also wait for work to be done onmain, causing a deadlock. I have moved these tests to run on a non-main global queue to avoid this trap.CI on this code has run ten times without failure, validating the hypothesis.