chore(ICP-Rosetta): FI-1467 remove basic tests smoke test #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolasHai
changed the base branch from
FI-1465-sign-icp-transfers
to
master
mbjorkqvist
reviewed
Sep 11, 2024
There was a problem hiding this comment.
Thanks for this restructuring, @NikolasHai! I left mainly minor comments, but I did find that the test_cases::account_balances::test_account_balances seems flaky, so that's something that should be addressed before merging.
For completeness, could you also add the description from this PR into the JIRA ticket?
rs/rosetta-api/tests/system_tests/test_cases/account_balances.rs
Outdated
Show resolved
Hide resolved
rs/rosetta-api/tests/system_tests/test_cases/block_synchronization.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
…tion.rs Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
mbjorkqvist
approved these changes
Sep 11, 2024
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
This MR introduces the following changes: 1. Remove the block test from basic tests 2. Remove the account balance test from basic tests (Covered by this MR: #1296) 3. Add tests for fetching blocks 4. Add tests for search transactions by index --------- Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
This MR proposes the following changes: 1. Remove the basic_tests smoke test 2. Create tests for account balances 3. Create tests for construction derive 4. Create tests for construction metadata 5. Create tests for Network Options and List 6. Create tests for Mempool --------- Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
This MR introduces the following changes: 1. Remove the block test from basic tests 2. Remove the account balance test from basic tests (Covered by this MR: dfinity#1296) 3. Add tests for fetching blocks 4. Add tests for search transactions by index --------- Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR proposes the following changes: