Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ICP-Rosetta): FI-1473: remove block test #1413

Merged
merged 53 commits into from
Sep 17, 2024

Conversation

NikolasHai
Copy link
Contributor

This MR introduces the following changes:

  1. Remove the block test from basic tests
  2. Remove the account balance test from basic tests (Covered by this MR: chore(ICP-Rosetta): FI-1467 remove basic tests smoke test #1296)
  3. Add tests for fetching blocks
  4. Add tests for search transactions by index

@github-actions github-actions bot added the chore label Sep 10, 2024
@NikolasHai NikolasHai marked this pull request as ready for review September 12, 2024 12:48
@NikolasHai NikolasHai requested a review from a team as a code owner September 12, 2024 12:48
Copy link
Member

@mbjorkqvist mbjorkqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NikolasHai, LGTM!

…ns.rs

Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
@NikolasHai NikolasHai added this pull request to the merge queue Sep 17, 2024
Merged via the queue into master with commit 775b650 Sep 17, 2024
23 of 24 checks passed
@NikolasHai NikolasHai deleted the FI-1473-remove-block-test branch September 17, 2024 15:10
levifeldman pushed a commit to levifeldman/ic that referenced this pull request Oct 1, 2024
This MR introduces the following changes: 

1. Remove the block test from basic tests
2. Remove the account balance test from basic tests (Covered by this MR:
dfinity#1296)
3. Add tests for fetching blocks
4. Add tests for search transactions by index

---------

Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants