chore(sns): Migrate SNS Root's wasm_memory_limit #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
reviewed
Sep 17, 2024
max-dfinity
approved these changes
Sep 17, 2024
anchpop
force-pushed
the
@anchpop/migrate-root-canister-wasm_memory_limit
branch
from
c466fa9
to
ee74824
Compare
anchpop
deleted the
@anchpop/migrate-root-canister-wasm_memory_limit
branch
cgundy
added a commit
that referenced
this pull request
Sep 18, 2024
…)"" This reverts commit f17a5d4.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
…sters (#1540) All the non-governance and non-root SNS canisters should have their `wasm_memory_limit` set to 3GiB via a root migration. (#1521 took care of this for root via a governance migration.) Once this PR is merged and released, all SNS canisters will have the same `wasm_memory_limit` - 4GiB for SNS Governance, 3GiB for all other canisters. I've already verified with the FI team that 3GiB is safe to use with all 3 FI canisters. Closes [NNS1-3301](https://dfinity.atlassian.net/browse/NNS1-3301) [NNS1-3301]: https://dfinity.atlassian.net/browse/NNS1-3301?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
dfinity#1427 made this change for the root canisters of new SNSes. This PR ensures that all root canisters have the expected settings by migrating existing SNSes. The change changes their settings to set wasm_memory_limit to 3GiB. This should be safe – no root canister uses anything close to 3GiB.
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
…sters (dfinity#1540) All the non-governance and non-root SNS canisters should have their `wasm_memory_limit` set to 3GiB via a root migration. (dfinity#1521 took care of this for root via a governance migration.) Once this PR is merged and released, all SNS canisters will have the same `wasm_memory_limit` - 4GiB for SNS Governance, 3GiB for all other canisters. I've already verified with the FI team that 3GiB is safe to use with all 3 FI canisters. Closes [NNS1-3301](https://dfinity.atlassian.net/browse/NNS1-3301) [NNS1-3301]: https://dfinity.atlassian.net/browse/NNS1-3301?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
## Problem In dfinity#1540 and dfinity#1521, we added code for performing a migration of wasm_memory_limit for all SNS canisters other than SNS Governance. That code is no longer necessary now that it has been released. ## Solution Remove that code. A few changes to tests are still useful and have been left in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1427 made this change for the root canisters of new SNSes. This PR ensures that all root canisters have the expected settings by migrating existing SNSes.
The change changes their settings to set wasm_memory_limit to 3GiB. This should be safe – no root canister uses anything close to 3GiB.