chore(sns): Remove wasm_memory_limit migration code #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/NNS1-3368
branch
from
4b9ab83
to
ad3d599
Compare
anchpop
force-pushed
the
@anchpop/NNS1-3368
branch
from
ad3d599
to
9844d2b
Compare
anchpop
force-pushed
the
@anchpop/NNS1-3368
branch
from
9844d2b
to
3badb25
Compare
max-dfinity
approved these changes
Sep 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
## Problem In dfinity#1540 and dfinity#1521, we added code for performing a migration of wasm_memory_limit for all SNS canisters other than SNS Governance. That code is no longer necessary now that it has been released. ## Solution Remove that code. A few changes to tests are still useful and have been left in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In #1540 and #1521, we added code for performing a migration of wasm_memory_limit for all SNS canisters other than SNS Governance. That code is no longer necessary now that it has been released.
Solution
Remove that code. A few changes to tests are still useful and have been left in.