fix: commands with --all parameter skip remote canisters #4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesi200
approved these changes
Nov 26, 2024
ericswanson-dfinity
deleted the
ens/sdk-1784-exclude-remote-canisters
branch
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the following commands such that they skip remote canisters when the
--allparameter is passed:dfx canister deletedfx canister deposit-cyclesdfx canister startdfx canister statusdfx canister stopdfx canister uninstall-codedfx canister update-settingsdfx ledger fabricate-cyclesFixes https://dfinity.atlassian.net/browse/SDK-1784
How Has This Been Tested?
Updated e2e tests
Checklist: