adjustNamespaces: Prevent infinite children loop #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
POC: <?php
require_once __DIR__ . '/src/Feed.php';
$feed = Feed::loadRss('https://github.com/dg/rss-php/files/9019437/bad.rss.txt');
// infinite loop
var_dump($feed->title); |
|
Friendly monthly ping @dg |
|
Monthly ping @dg |
|
Hourly ping @dg :P |
|
Thanks, fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David,
I came across rss (bad.rss.txt) that cause this piece of code to infinitely loop.
I am not rss nor xml expert so I do not know root cause but this patch fix it for me but I do not know if it is good solution?