extends to support String ( instead of URL ) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beavermml
commented
Jul 2, 2014
beavermml
commented
- now can receive String in case of saving the RSS/Atom into the database
- now can receive String in case of saving the RSS/Atom into the database
|
I dont understand purpose of this PR. file_get_contents never throws exceptions. |
|
in my case, i send the string of RSS ( not file/url ) to the function.. it throws error when i put string in it.. |
|
PHP functions do not throw exceptions. Sorry I dont understand where is a problem, but this fix is not good. |
|
it is just a hack to my app so that it can use string of XML ( "<?xml .... >" ) instead of URL ( "http:// " ) or file ( "xml.rss" ).. i am sorry.. i am not too good at PHP programming.. i just thought if your app can support strings of XML instead of only URL or files it will be much better.. |
|
ok.. sorry.. i redid my code.. it seems the exception is thrown because something else.. sorry to distirb your time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.