Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Feature request: Allow querying weather service to be optional feature #4

Closed
paulrobertlloyd opened this issue Feb 3, 2018 · 3 comments

Comments

@paulrobertlloyd
Copy link

Hello,

Thank-you so much for addressing #3. I’m stumbling across a few things as I try to install this on my own server, so thought I would file issues as I come across them. Hope you don’t mind?

Okay, so the first issue is that setting up Compass is non-trivial, and I’m not sure necessary for basic functionality (although I am curious, so might set this up in the future). Ideally, this would be an optional feature, that would only be activated should the required configuration/keys be available.

For the moment, I have just commented out the following lines, which seems to do the trick:

// $weather = getWeather();
// $frontmatter = array_merge($frontmatter, $weather);
@paulrobertlloyd paulrobertlloyd changed the title Allow querying weather service to be optional feature Feature request: Allow querying weather service to be optional feature Feb 3, 2018
@dg01d
Copy link
Owner

dg01d commented Feb 4, 2018

This is something I'd already been working on. Will be done very soon.

dg01d added a commit that referenced this issue Feb 4, 2018
dg01d added a commit that referenced this issue Feb 4, 2018
@dg01d
Copy link
Owner

dg01d commented Feb 4, 2018

I have provided a switch in configs.php for this. My testing server acts as expected. Please test and confirm.

@paulrobertlloyd
Copy link
Author

Can confirm that setting toggle to false fixes this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants