-
Notifications
You must be signed in to change notification settings - Fork 91
Update protobufs to match those in dgo and fix tests. #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bcbb273
to
fe0cd6d
Compare
tests/helper.py, line 46 at r3 (raw file):
You should be able to simply change this one line and the rest of the tests will pick it the correct Dgraph Alpha address from here. |
tests/helper.py, line 76 at r3 (raw file):
Update docstring since it's no longer doing version checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 2 of 5 files at r2, 2 of 2 files at r3.
Reviewable status: 6 of 9 files reviewed, 2 unresolved discussions (waiting on @martinmr and @danielmai)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r2.
Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @danielmai and @martinmr)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @danielmai)
tests/helper.py, line 46 at r3 (raw file):
Previously, danielmai (Daniel Mai) wrote…
You should be able to simply change this one line and the rest of the tests will pick it the correct Dgraph Alpha address from here.
Done.
tests/helper.py, line 76 at r3 (raw file):
Previously, danielmai (Daniel Mai) wrote…
Update docstring since it's no longer doing version checking.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
Fixes #32
This change is