Skip to content

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Dec 20, 2018

  • Update protobufs and generated files.
  • Update tests to use port 9180 to match the port used by the tests scripts.
  • Add script to run tests locally (assumes Dgraph is already installed to prevent "go get" from rewriting local changes.
  • Update test documentation in README.

Fixes #32


This change is Reviewable

@martinmr martinmr requested a review from danielmai December 20, 2018 01:24
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 50

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 95.545%

Totals Coverage Status
Change from base Build 39: 0.5%
Covered Lines: 193
Relevant Lines: 202

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 20, 2018

Pull Request Test Coverage Report for Build 57

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.05%

Totals Coverage Status
Change from base Build 39: 0.0%
Covered Lines: 192
Relevant Lines: 202

💛 - Coveralls

@martinmr martinmr force-pushed the martinmr/update-protobuf branch from bcbb273 to fe0cd6d Compare December 20, 2018 18:39
@danielmai
Copy link
Contributor


tests/helper.py, line 46 at r3 (raw file):

SERVER_ADDR = 'localhost:9080'

You should be able to simply change this one line and the rest of the tests will pick it the correct Dgraph Alpha address from here.

@danielmai
Copy link
Contributor


tests/helper.py, line 76 at r3 (raw file):

    def setUp(self):
        """Sets up the client and verifies the version is compatible."""

Update docstring since it's no longer doing version checking.

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 2 of 5 files at r2, 2 of 2 files at r3.
Reviewable status: 6 of 9 files reviewed, 2 unresolved discussions (waiting on @martinmr and @danielmai)

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments. :lgtm:

Reviewed 3 of 5 files at r2.
Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @danielmai and @martinmr)

Copy link
Contributor Author

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @danielmai)


tests/helper.py, line 46 at r3 (raw file):

Previously, danielmai (Daniel Mai) wrote…

You should be able to simply change this one line and the rest of the tests will pick it the correct Dgraph Alpha address from here.

Done.


tests/helper.py, line 76 at r3 (raw file):

Previously, danielmai (Daniel Mai) wrote…

Update docstring since it's no longer doing version checking.

Done.

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit 72bc251 into master Dec 20, 2018
@martinmr martinmr deleted the martinmr/update-protobuf branch December 20, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants