Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tasty-expected-failure to skip tests #1245

Closed
sjakobi opened this issue Aug 21, 2019 · 1 comment · Fixed by #1250
Closed

Use tasty-expected-failure to skip tests #1245

sjakobi opened this issue Aug 21, 2019 · 1 comment · Fixed by #1250

Comments

@sjakobi
Copy link
Collaborator

sjakobi commented Aug 21, 2019 •
edited
Loading

Marking broken tests with expectFail would allow us to immediately notice if we fix a test or if the test is (re)moved as they sometimes do.
Gabriella439 added a commit that referenced this issue Aug 27, 2019
@Gabriella439
Use tasty-expected-failure
de2fbdb 
... to exercise tests that we currently skip

Fixes #1245
@Gabriella439 Gabriella439 mentioned this issue Aug 27, 2019
Merged
@Gabriella439
Copy link
Collaborator

Fix is up here: #1250

@mergify mergify bot closed this as completed in #1250 Aug 30, 2019
mergify bot pushed a commit that referenced this issue Aug 30, 2019
@Gabriella439 @mergify
Use tasty-expected-failure (#1250)
4445eee 
* Use `tasty-expected-failure`

... to exercise tests that we currently skip

Fixes #1245

* Fix bounds syntax for `tasty-expected-failure`

... as caught by @sjakobi

Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>

* Fix GHC 8.6 build failure

`tasty-expected-failure` needs to be bumped to include revision 1, which
supports GHC 8.6

* Fix build failure for older `tasty-hunit` versions

`tasty-hunit-0.9.2` and older have the wrong type for `assertFailure`

* Fix `stack` build for LTS 6

... and sort the list of `extra-deps`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use tasty-expected-failure dhall-lang/dhall-haskell
2 participants
@Gabriella439 @sjakobi