Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why doesn't "dhall type" support imports? #1277

Closed
sjakobi opened this issue Sep 3, 2019 · 1 comment · Fixed by #1281
Closed

Why doesn't "dhall type" support imports? #1277

sjakobi opened this issue Sep 3, 2019 · 1 comment · Fixed by #1281

Comments

@sjakobi
Copy link
Collaborator

sjakobi commented Sep 3, 2019

Currently it outputs

Import resolution is disabled

when the given expression contains an import.

Is there a reason why it shouldn't try to resolve imports?
@sjakobi sjakobi transferred this issue from dhall-lang/dhall-lang Sep 3, 2019
@Gabriella439
Copy link
Collaborator

@sjakobi: No good reason. When I initially added the dhall {resolve,type,normalize} subcommands the rationale was that each would only execute one phase of the interpretation pipeline, but in retrospect I think it was a mistake and think that dhall type should resolve imports like you request

Gabriella439 added a commit that referenced this issue Sep 5, 2019
@Gabriella439
Change dhall type to resolve imports
10c1d65 
Fixes #1277

The original motivation was that `dhall type` would represent a
type-inference-only phase.  However, in practice that wasn't very useful
so `dhall type` now performs import resolution followed by type inference.
@Gabriella439 Gabriella439 mentioned this issue Sep 5, 2019
Merged
@mergify mergify bot closed this as completed in #1281 Sep 5, 2019
mergify bot pushed a commit that referenced this issue Sep 5, 2019
@Gabriella439 @sjakobi @mergify
Change dhall type to resolve imports (#1281)
8c8ea2a 
* Change `dhall type` to resolve imports

Fixes #1277

The original motivation was that `dhall type` would represent a
type-inference-only phase.  However, in practice that wasn't very useful
so `dhall type` now performs import resolution followed by type inference.

* Fix loading relative to root directory

... as caught by @sjakobi

Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change dhall type to resolve imports dhall-lang/dhall-haskell
2 participants
@Gabriella439 @sjakobi