Remove a redundant check of list annotations #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
force-pushed
the
sjakobi/1359-list-lits-p1
branch
2 times, most recently
from
ab44c43
to
b4a15ad
Compare
Gabriella439
reviewed
Oct 2, 2019
Gabriella439
approved these changes
Oct 2, 2019
* Remove a redundant check of the type annotation. * Replace dead code for processing the list elements with an error. * Document the ListLit invariant. Closes #1359.
sjakobi
force-pushed
the
sjakobi/1359-list-lits-p1
branch
from
ee8b55e
to
be08cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses item 1 of #1359.
Also add a FIXME for item 2.