List dependencies in "post-order" #1539

Gabriella439 · 2019-11-14T16:46:33Z

Related to https://github.com/dhall-lang/dhall-lang/issues/823

This lists dependencies starting from the leaves and concluding with the root
import, same as how nix-store --query --requisites does

Example output:

$ dhall resolve --no-cache --transitive-dependencies <<< 'https://prelude.dhall-lang.org/package.dhall'
https://prelude.dhall-lang.org/Bool/and
https://prelude.dhall-lang.org/Bool/build
https://prelude.dhall-lang.org/Bool/even
https://prelude.dhall-lang.org/Bool/fold
https://prelude.dhall-lang.org/Bool/not
https://prelude.dhall-lang.org/Bool/odd
https://prelude.dhall-lang.org/Bool/or
https://prelude.dhall-lang.org/Bool/show
https://prelude.dhall-lang.org/Bool/package.dhall
https://prelude.dhall-lang.org/Double/show
https://prelude.dhall-lang.org/Double/package.dhall
https://prelude.dhall-lang.org/Function/compose
https://prelude.dhall-lang.org/Function/package.dhall
https://prelude.dhall-lang.org/Integer/show
https://prelude.dhall-lang.org/Integer/toDouble
https://prelude.dhall-lang.org/Integer/package.dhall
https://prelude.dhall-lang.org/List/all
https://prelude.dhall-lang.org/List/any
https://prelude.dhall-lang.org/List/build
https://prelude.dhall-lang.org/List/concat
https://prelude.dhall-lang.org/List/concatMap
https://prelude.dhall-lang.org/List/default
https://prelude.dhall-lang.org/List/empty
https://prelude.dhall-lang.org/List/filter
https://prelude.dhall-lang.org/List/fold
https://prelude.dhall-lang.org/List/generate
https://prelude.dhall-lang.org/List/head
https://prelude.dhall-lang.org/List/indexed
https://prelude.dhall-lang.org/List/iterate
https://prelude.dhall-lang.org/List/last
https://prelude.dhall-lang.org/List/length
https://prelude.dhall-lang.org/List/map
https://prelude.dhall-lang.org/List/null
https://prelude.dhall-lang.org/List/partition
https://prelude.dhall-lang.org/List/replicate
https://prelude.dhall-lang.org/List/reverse
https://prelude.dhall-lang.org/List/shifted
https://prelude.dhall-lang.org/List/unzip
https://prelude.dhall-lang.org/List/package.dhall
https://prelude.dhall-lang.org/Location/Type
https://prelude.dhall-lang.org/Location/package.dhall
https://prelude.dhall-lang.org/Map/Type
https://prelude.dhall-lang.org/Map/Entry
https://prelude.dhall-lang.org/Map/empty
https://prelude.dhall-lang.org/Map/keyText
https://prelude.dhall-lang.org/Map/keyValue
https://prelude.dhall-lang.org/Map/keys
https://prelude.dhall-lang.org/Map/map
https://prelude.dhall-lang.org/Map/values
https://prelude.dhall-lang.org/Map/package.dhall
https://prelude.dhall-lang.org/Monoid
https://prelude.dhall-lang.org/Natural/build
https://prelude.dhall-lang.org/Natural/enumerate
https://prelude.dhall-lang.org/Natural/even
https://prelude.dhall-lang.org/Natural/fold
https://prelude.dhall-lang.org/Natural/isZero
https://prelude.dhall-lang.org/Natural/odd
https://prelude.dhall-lang.org/Natural/product
https://prelude.dhall-lang.org/Natural/sum
https://prelude.dhall-lang.org/Natural/show
https://prelude.dhall-lang.org/Natural/toDouble
https://prelude.dhall-lang.org/Natural/toInteger
https://prelude.dhall-lang.org/Natural/lessThanEqual
https://prelude.dhall-lang.org/Natural/greaterThanEqual
https://prelude.dhall-lang.org/Natural/lessThan
https://prelude.dhall-lang.org/Natural/equal
https://prelude.dhall-lang.org/Natural/greaterThan
https://prelude.dhall-lang.org/Natural/min
https://prelude.dhall-lang.org/Natural/max
https://prelude.dhall-lang.org/Optional/map
https://prelude.dhall-lang.org/Natural/listMin
https://prelude.dhall-lang.org/Natural/listMax
https://prelude.dhall-lang.org/Natural/sort
https://prelude.dhall-lang.org/Natural/subtract
https://prelude.dhall-lang.org/Natural/package.dhall
https://prelude.dhall-lang.org/Optional/all
https://prelude.dhall-lang.org/Optional/any
https://prelude.dhall-lang.org/Optional/build
https://prelude.dhall-lang.org/Optional/concat
https://prelude.dhall-lang.org/Optional/default
https://prelude.dhall-lang.org/Optional/filter
https://prelude.dhall-lang.org/Optional/fold
https://prelude.dhall-lang.org/Optional/head
https://prelude.dhall-lang.org/Optional/last
https://prelude.dhall-lang.org/Optional/length
https://prelude.dhall-lang.org/Optional/null
https://prelude.dhall-lang.org/Optional/toList
https://prelude.dhall-lang.org/Optional/unzip
https://prelude.dhall-lang.org/Optional/package.dhall
https://prelude.dhall-lang.org/JSON/Type
https://prelude.dhall-lang.org/JSON/Nesting
https://prelude.dhall-lang.org/JSON/Tagged
https://prelude.dhall-lang.org/JSON/keyText
https://prelude.dhall-lang.org/JSON/keyValue
https://prelude.dhall-lang.org/JSON/string
https://prelude.dhall-lang.org/JSON/number
https://prelude.dhall-lang.org/JSON/object
https://prelude.dhall-lang.org/JSON/array
https://prelude.dhall-lang.org/JSON/bool
https://prelude.dhall-lang.org/JSON/null
https://prelude.dhall-lang.org/Text/concatMapSep
https://prelude.dhall-lang.org/JSON/render
https://prelude.dhall-lang.org/JSON/package.dhall
https://prelude.dhall-lang.org/Text/concat
https://prelude.dhall-lang.org/Text/concatMap
https://prelude.dhall-lang.org/Text/concatSep
https://prelude.dhall-lang.org/Text/default
https://prelude.dhall-lang.org/Text/defaultMap
https://prelude.dhall-lang.org/Text/show
https://prelude.dhall-lang.org/Text/package.dhall
https://prelude.dhall-lang.org/XML/Type
https://prelude.dhall-lang.org/XML/attribute
https://prelude.dhall-lang.org/XML/render
https://prelude.dhall-lang.org/XML/element
https://prelude.dhall-lang.org/XML/leaf
https://prelude.dhall-lang.org/XML/text
https://prelude.dhall-lang.org/XML/emptyAttributes
https://prelude.dhall-lang.org/XML/package.dhall
https://prelude.dhall-lang.org/package.dhall

sjakobi

Nice! 👍

It might be good to document this behaviour – I'm not sure which place would be best. In the usage info, on ListTransitiveDependencies?

@sjakobi

... as suggested by @sjakobi

retnuh · 2019-11-14T17:01:59Z

Thanks for responding so fast! Just a quick look - given that Dhall.Map respects the insertion order, it leverages that fact in the walk? There's a comment about re-insertion overriding the order, but at a guess there's no need to re-insert?

Gabriella439 · 2019-11-14T17:04:11Z

@retnuh: I believe it will not reinsert the same import because it will be a cache hit the second time it attempts to import it

sjakobi · 2019-11-17T16:14:18Z

dhall-lsp-server needs fixing:

    C:\projects\dhall-haskell\dhall-lsp-server\src\Dhall\LSP\Backend\Dhall.hs:140:32: error:
        * Couldn't match expected type `Dhall.Map.Map
                                          Dhall.Chained Dhall.ImportSemantics'
                      with actual type `Map.Map Dhall.Chained Dhall.ImportSemantics'
          NB: `Map.Map'
                is defined in `Data.Map.Internal' in package `containers-0.6.0.1'
              `Dhall.Map.Map' is defined in `Dhall.Map' in package `dhall-1.27.0'
        * In the second argument of `set', namely `cache'
          In the first argument of `(.)', namely `set Dhall.cache cache'
          In the expression:
            set Dhall.cache cache
              . set Dhall.graph graph . set Dhall.stack (chained :| [])
        |
    140 |                set Dhall.cache cache .
        |                                ^^^^^
    
    C:\projects\dhall-haskell\dhall-lsp-server\src\Dhall\LSP\Backend\Dhall.hs:148:38: error:
        * Couldn't match expected type `Map.Map
                                          Dhall.Chained Dhall.ImportSemantics'
                      with actual type `Dhall.Map.Map
                                          Dhall.Chained Dhall.ImportSemantics'
          NB: `Dhall.Map.Map'
                is defined in `Dhall.Map' in package `dhall-1.27.0'
              `Map.Map'
                is defined in `Data.Map.Internal' in package `containers-0.6.0.1'
        * In the second argument of `Cache', namely cache'
          In the expression: Cache graph' cache'
          In the second argument of `($)', namely
            `(Cache graph' cache', expr')'
        |
    148 |       return . Right $ (Cache graph' cache', expr'))
        |                                      ^^^^^^
Command exited with code 1

sjakobi · 2019-11-21T14:07:37Z

@Gabriel439 I have pushed a fix for dhall-lsp-server to your branch, so this can (hopefully) get merged.

Gabriella439 · 2019-11-21T16:27:03Z

@sjakobi: Thank you! Sorry, I've been busy preparing for a talk over the last week

sjakobi · 2019-11-21T16:28:59Z

No worries! You're welcome! :)

sjakobi approved these changes Nov 14, 2019

View reviewed changes

Document order in dhall resolve --help output

b2b45c6

... as suggested by @sjakobi

Gabriella439 added the merge me label Nov 14, 2019

Fix dhall-lsp-server build

6adc0a7

Merge branch 'master' into gabriel/order_dependencies

3441ee7

mergify bot merged commit 5f15c86 into master Nov 21, 2019

mergify bot deleted the gabriel/order_dependencies branch November 21, 2019 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

List dependencies in "post-order" #1539

List dependencies in "post-order" #1539

Gabriella439 commented Nov 14, 2019

sjakobi left a comment

retnuh commented Nov 14, 2019

Gabriella439 commented Nov 14, 2019

sjakobi commented Nov 17, 2019

sjakobi commented Nov 21, 2019

Gabriella439 commented Nov 21, 2019

sjakobi commented Nov 21, 2019

List dependencies in "post-order" #1539

List dependencies in "post-order" #1539

Conversation

Gabriella439 commented Nov 14, 2019

sjakobi left a comment

Choose a reason for hiding this comment

retnuh commented Nov 14, 2019

Gabriella439 commented Nov 14, 2019

sjakobi commented Nov 17, 2019

sjakobi commented Nov 21, 2019

Gabriella439 commented Nov 21, 2019

sjakobi commented Nov 21, 2019