Skip to content

Simplify dhall-to-nix code #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2022
Merged

Simplify dhall-to-nix code #2389

merged 2 commits into from
Feb 20, 2022

Conversation

Gabriella439
Copy link
Collaborator

… by making use of the available short-hand utilities

@Gabriella439
Simplify dhall-to-nix code
0c5000e 
… by making use of the available short-hand utilities
@Gabriella439
Undo changes to implementation of Text/replace
d759779 
You want `Nix.mkStr "…"` instead of `"…"` since the latter is a
variable, not a string literal
@Gabriella439
Copy link
Collaborator Author

This also contains a few changes to the implementation of certain utilities:

  • Natural/{even,odd} now use a much more efficient implementation
  • A few unnecessary lets were removed

@Gabriella439 Gabriella439 merged commit 97ad9ac into master Feb 20, 2022
@Gabriella439 Gabriella439 deleted the gabriella/simplify_dhall-to-nix branch February 20, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gabriella439