Skip to content

Conversation

gilligan
Copy link
Collaborator

Fixes #408

  • inputFromFile reads file and invokes Dhall.input
  • inputExprFromFile reads file and invokes Dhall.inputExpr

That was a quick one, did I miss something? 😅

- `inputFromFile` reads file and invokes Dhall.input
- `inputExprFromFile` reads file and invokes Dhall.inputExpr
@quasicomputational
Copy link
Collaborator

This will mean that the errors aren't going to be great, since they'll report (input) as their location rather than the file name. Coincidentally I just put up a small PR earlier, #464, which would make it very easy to fix that.

@gilligan
Copy link
Collaborator Author

@quasicomputational Oh, right. I hadn't thought about that. If your PR gets merged i'm happy to rebase and adjust!

@Gabriella439
Copy link
Collaborator

Closing as I believe this was superseded by #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants