Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss - drop support for GHC-7.6? #59

Merged
merged 2 commits into from
Dec 2, 2015
Merged

Discuss - drop support for GHC-7.6? #59

merged 2 commits into from
Dec 2, 2015

Conversation

bergey
Copy link
Member

@bergey bergey commented Nov 27, 2015

Building on 7.6 has been impossible since
71f6539 which added a dependency on
cubicbezier, which requires containers >= 0.5.3, whereas GHC-7.6 has
template-haskell built against containers 0.5.0.

Are folks OK dropping 7.6 now?

@kuribas - Is it possible for cubicbezier to support containers-0.5.0? How hard would it be?

Tangentially, we should probably restrict our travis builds to template-haskell installed. The failed builds here try to rebuild template-haskell with newer containers, which I doubt is ever an acceptable solution.

Building on 7.6 has been impossible since
71f6539 which added a dependency on
cubicbezier, which requires containers >= 0.5.3, whereas GHC-7.6 has
template-haskell built against containers 0.5.0.
@byorgey
Copy link
Member

byorgey commented Nov 30, 2015

Yeah, I'm fine with dropping 7.6, especially if we wait until after GHC 8.0 lands to cut a major new release (which seems basically guaranteed at this point).

I wonder if we should start being explicit about which stack resolvers we support.

@byorgey
Copy link
Member

byorgey commented Nov 30, 2015

I notice you didn't remove the line listing GHC 7.4, I assume we should remove that as well?

@bergey
Copy link
Member Author

bergey commented Nov 30, 2015

Yes, we should certainly remove the line for GHC 7.4. It's in allow_failures, so it doesn't bug me as much =).

I'd like to test on Stackage LTS-3; not sure beyond that. That should fill the hole where we don't have HP-2015. I haven't yet tried to make travis run some tests with stack & some with cabal. It shouldn't be very hard. I'll have a PR soon about testing -builder with stack, since it hasn't passed CI in ages.

bergey added a commit that referenced this pull request Dec 2, 2015
Discuss - drop support for GHC-7.6?
@bergey bergey merged commit 1fbaa07 into master Dec 2, 2015
@jeffreyrosenbluth
Copy link
Member

Fine by me

On Wed, Dec 2, 2015 at 2:26 PM Daniel Bergey notifications@github.com
wrote:

Merged #59 #59.


Reply to this email directly or view it on GitHub
#59 (comment).

@bergey bergey deleted the travis-drop-ghc-7.6 branch December 12, 2015 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants