feat(visual-testing): poc percy visual testing #357

juliodialpad · 2022-05-16T20:54:32Z

Teat(visual testing): Dt 398 poc percy visual testing

🛠️ Type Of Change

Fix
Feature
Refactoring
Documentation

📖 Description

I need to create a PR to test that github actions workflow is working correctly

Added percy visual tests to deploy-preview workflow

💡 Context

We need a way to visually test or components, this is a POC to check capabilities of Percy

📝 Checklist

I have updated library exports
I have reviewed my changes
I have added tests
I have added all relevant documentation
All tests are passing
All linters are passing
No accessibility issues reported
I have validated components with a screen reader
I have validated components keyboard navigation

# Conflicts: # package-lock.json # package.json

github-actions · 2022-05-16T20:54:48Z

Thanks for contributing to Dialtone Vue! Please read below for some important info regarding Vue 3 compatibility.

Currently we need to maintain two branches in Dialtone Vue, one for Vue 2, one for Vue 3.

This means you must create two PRs for every feature change you make. One into staging and one into staging-vue3.

Many times the change you have made in Vue 2 will be identical to the change you need to make in Vue 3. To make this easier we have made a script that can copy your changes from this branch to a new branch off of staging-vue3 suffixed with -vue3.

run ./copy_pr_vue3.sh from the root dialtone-vue directory.

Once the new branch is created, you will need to look at your code to make sure it still makes sense and test that your changes all work in vue 3. If everything is good you can push it and create a PR into staging-vue3.

It is a required check for every PR to have a corresponding branch called yourbranch-vue3 so that we do not forget to do it. In the special case that you need to make a change to vue2 without making it in vue3, you can set the label vue2-only on this PR.

What if I make more changes to my vue 2 branch after running ./copy_pr_vue3.sh?

You can copy these to the existing -vue3 branch by running the script with a git SHA param like so:

./copy_pr_vue3.sh 2a78db7

where 2a78db7 is the last commit from your branch that was copied to the other branch (all commits after this will be copied)

If it's just one or two commits, you may prefer to just manually use git cherry-pick which will work fine as well.

What if I get a conflict?

Its possible to get a conflict when running copy_pr_vue3.sh. If this happens you can manually fix the conflict, commit it and do git rebase --continue and then git rebase HEAD yourbranch-vue3. Your other option is to do git rebase --abort and make the change manually.

github-actions · 2022-05-16T20:58:14Z