Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcancel.Cancellable does not inherit parent properly #39

Closed
diamondburned opened this issue Oct 6, 2021 · 1 comment
Closed

gcancel.Cancellable does not inherit parent properly #39

diamondburned opened this issue Oct 6, 2021 · 1 comment
Labels
bug Changes to fix bugs that do not require refactoring enhancement New feature or request

Comments

@diamondburned
Copy link
Owner

The current design of gcancel.Cancellable doesn't inherit the context
properly, so the WithCancel()'s API is actually invalid.

This should be a trivial fix.
@diamondburned diamondburned added enhancement New feature or request bug Changes to fix bugs that do not require refactoring labels Oct 6, 2021
diamondburned added a commit that referenced this issue Oct 12, 2021
@diamondburned
Fix gcancel; closes issue #39
4b25d91
@diamondburned
Copy link
Owner Author

Closed by 4b25d91.

@fleshin fleshin mentioned this issue Apr 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Changes to fix bugs that do not require refactoring enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diamondburned