Repository navigation
Replies: 2 comments 1 reply
|
This is an artifact-packaging bug, not a missing CMake flag. In the referenced run, CMake copied both In the existing + build-ninja-vcpkg-relwithdebinfo/lua.dll
- build-ninja-vcpkg-relwithdebinfo/zlib1.dll
+ build-ninja-vcpkg-relwithdebinfo/z.dllI also checked the downloaded artifact: The 1.5.5 zip is not an equivalent MSVC build. Its MinGW x64 workflow deliberately avoids dynamic zlib, and 1.5.5 predates the Lua dependency now present on So I would fix the MSVC artifact list and rerun it. If you specifically want the official release's linking/package layout, use the MinGW x64 workflow; this MSVC workflow is designed to ship runtime DLLs alongside the executable. |
|
Thank you both so much for the clear explanations! @CasperKristiansson, I really appreciate the detailed breakdown of the artifact packaging issue. Thank you for pointing me towards the MinGW x64 workflow for a self-contained executable. That is exactly what I was looking for! @AJenbo, thanks for clarifying the purpose of the MSVC build. As someone who is fairly new to building from source, this clears up a lot of my confusion. I will switch to the MinGW workflow now. Thanks again for your time and help! 😊🙏🏻 |
Uh oh!
There was an error while loading. Please reload this page.
I built DevilutionX from my fork's GitHub Actions (Windows_MSVC_x64.yml workflow). The build completed successfully and I downloaded the resulting devilutionx.exe artifact, but when I try to launch it, I get an error that z.dll and lua.dll cannot be found.
I compared this against the official 1.5.5 release (devilutionx-windows-x86_64.zip) and noticed the official build doesn't ship with either of those DLLs at all — so I'm guessing my CI build might be linking these dependencies dynamically instead of statically, but I'm not sure how to fix that.
Build run for reference: https://github.com/mrBigHub/DevilutionX/actions/runs/31929614996
Is there a build setting or CMake flag I'm missing to get a self-contained exe like the official release? Any pointers appreciated — I'm fairly new to building from source. My OS is Windows10.
All reactions