Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] Better dag handling #69
Don't print to stdout if building a
I think having the --dag flag to dump straight to output is a good idea, so that you can pipe it to scripts or other command line utilities, but I also think it's good to have a flag to dump to a file or to a png.
I implemented a context manager that will capture stdout when the user is creating the directed acyclic graph, and either prints it to the screen (in the case of --dag, which will continue to work as you implemented it), or prints it to a file (if the user passes the --dagfile flag), or uses dot to convert the dotfile into a png file (if the user passes the --dagpng flag).
I opened a pull request (#73) against this pull request so you can take a look. I'll also add a few tests of the new functionality.
oh. well, I reviewed it already :)
On Mon, Feb 04, 2019 at 11:51:03AM -0800, Tessa Pierce wrote: it was merged into this branch/PR, not into master! -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #69 (comment)
-- C. Titus Brown, email@example.com