-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recast std::bad_alloc as a Python exception #704
Conversation
Jenkins, please test this |
Jenkins, retest this please |
How do we put automated tests in place for these branches - any thoughts? |
@ctb For the functions allocating table call them with outrageously huge table sizes. |
Blargh, OS X just kills the process instead of throwing the |
|
72eb09a
to
91a21ee
Compare
Jenkins, test this please |
@luizirber @ctb @camillescott Ready for review and merge |
@@ -162,7 +168,7 @@ diff-cover.html: coverage-gcovr.xml coverage.xml | |||
--html-report diff-cover.html | |||
|
|||
nosetests.xml: FORCE | |||
./setup.py nosetests --with-xunit | |||
./setup.py nosetests --with-xunit --attr ${TESTATTR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean we no longer need setup.cfg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup.cfg provides other default values and acts as a fallback if the Setuptools nosetests command is run outside of the Makefile
Conflicts: ChangeLog
recast std::bad_alloc as a Python exception
Will fix #111