Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure docs are tested in CI build #58

Merged
merged 2 commits into from
Dec 20, 2016
Merged

Make sure docs are tested in CI build #58

merged 2 commits into from
Dec 20, 2016

Conversation

standage
Copy link
Member

@standage standage commented Dec 19, 2016

Title says it all. Closes dib-lab/khmer#811.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality, is it tested?
  • make format diff_pylint_report doc Is it well formatted?
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@standage
Copy link
Member Author

Ready for review.

Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luizirber luizirber merged commit 6ad556b into master Dec 20, 2016
@luizirber luizirber deleted the ci/docbuild branch December 20, 2016 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants