chore: use fontkit mainline repo #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomura
force-pushed
the
dm/fontkit-mainline-repo
branch
2 times, most recently
from
6749ce1
to
8d48132
Compare
diegomura
force-pushed
the
dm/fontkit-mainline-repo
branch
5 times, most recently
from
41b8969
to
dea87d2
Compare
diegomura
force-pushed
the
dm/fontkit-mainline-repo
branch
from
dea87d2
to
f65c1c5
Compare
diegomura
force-pushed
the
dm/fontkit-mainline-repo
branch
from
98a56eb
to
5bff456
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove fontkit fork and return to mainline repo
We will need to produce a major release due to this PR, since new deps deps drop Node 12 support. This is a good thing though, since it's end of life of Node v12 was earlier this year. I's yet very likely a lot of people rely on Node 12 but going back to the mainline repo will have huge advantages (woff2 support in this case). But when doing pdfkit we will inherit all the new features in that project as well to add here
Fixes #577
Fixes #1712
Fixes #1451