Skip to content

Commit

Permalink
pythongh-108562: Revert enabling -fstrict-overflow for libmpdec (pyth…
Browse files Browse the repository at this point in the history
…onGH-116302)

pythongh-108562: partial reversion of pr114751

Reverts -fstrict-overflow for libmpdec
  • Loading branch information
skirpichev authored and diegorusso committed Apr 17, 2024
1 parent 42e883f commit ae18536
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
2 changes: 1 addition & 1 deletion Makefile.pre.in
Original file line number Diff line number Diff line change
Expand Up @@ -1213,7 +1213,7 @@ PYTHON_HEADERS= \

##########################################################################
# Build static libmpdec.a
LIBMPDEC_CFLAGS=$(PY_STDMODULE_CFLAGS) @LIBMPDEC_CFLAGS@ $(CCSHARED)
LIBMPDEC_CFLAGS=@LIBMPDEC_CFLAGS@ $(PY_STDMODULE_CFLAGS) $(CCSHARED)

# "%.o: %c" is not portable
Modules/_decimal/libmpdec/basearith.o: $(srcdir)/Modules/_decimal/libmpdec/basearith.c $(LIBMPDEC_HEADERS) $(PYTHON_HEADERS)
Expand Down
7 changes: 0 additions & 7 deletions configure

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -3896,11 +3896,6 @@ AS_VAR_IF([with_system_libmpdec], [yes], [
LIBMPDEC_LDFLAGS="-lm \$(LIBMPDEC_A)"
LIBMPDEC_INTERNAL="\$(LIBMPDEC_HEADERS) \$(LIBMPDEC_A)"
dnl Enable strict-overflow for libmpdec, if available, see GH-108562
AS_VAR_IF([ac_cv_cc_supports_fstrict_overflow], [yes], [
AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -fstrict-overflow"])
])
dnl Disable forced inlining in debug builds, see GH-94847
AS_VAR_IF([with_pydebug], [yes], [
AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -DTEST_COVERAGE"])
Expand Down

0 comments on commit ae18536

Please sign in to comment.