Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108562: Revert enabling -fstrict-overflow for libmpdec #116302

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Mar 4, 2024

Reverts -fstrict-overflow for libmpdec, added in #114751.

Reverts -fstrict-overflow for libmpdec
@erlend-aasland erlend-aasland changed the title gh-108562: partial reversion of pr114751 gh-108562: Revert enabling -fstrict-overflow for libmpdec #114751 Mar 4, 2024
@erlend-aasland erlend-aasland changed the title gh-108562: Revert enabling -fstrict-overflow for libmpdec #114751 gh-108562: Revert enabling -fstrict-overflow for libmpdec Mar 4, 2024
@erlend-aasland

This comment was marked as outdated.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ca35e50 🤖

The command will test the builders whose names match following regular expression: .*LTO.*

The builders matched are:

  • s390x Fedora Rawhide LTO + PGO PR
  • PPC64LE RHEL8 LTO + PGO PR
  • PPC64LE Fedora Rawhide LTO + PGO PR
  • aarch64 Fedora Rawhide LTO PR
  • PPC64LE Fedora Stable LTO PR
  • aarch64 RHEL8 LTO + PGO PR
  • PPC64LE Fedora Rawhide LTO PR
  • s390x RHEL7 LTO PR
  • s390x Fedora LTO + PGO PR
  • AMD64 Fedora Rawhide LTO + PGO PR
  • AMD64 RHEL8 LTO + PGO PR
  • s390x RHEL8 LTO + PGO PR
  • AMD64 CentOS9 LTO + PGO PR
  • s390x Fedora Rawhide LTO PR
  • AMD64 Fedora Rawhide LTO PR
  • AMD64 RHEL7 LTO + PGO PR
  • AMD64 Fedora Stable LTO PR
  • AMD64 RHEL7 LTO PR
  • PPC64LE RHEL7 LTO + PGO PR
  • PPC64LE RHEL8 LTO PR
  • PPC64LE Fedora Stable LTO + PGO PR
  • aarch64 Debian Clang LTO + PGO PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • aarch64 CentOS9 LTO PR
  • s390x RHEL7 LTO + PGO PR
  • aarch64 RHEL8 LTO PR
  • PPC64LE RHEL7 LTO PR
  • AMD64 CentOS9 LTO PR
  • aarch64 Fedora Stable LTO PR
  • AMD64 Fedora Stable LTO + PGO PR
  • aarch64 CentOS9 LTO + PGO PR
  • PPC64LE CentOS9 LTO PR
  • AMD64 RHEL8 LTO PR
  • aarch64 Fedora Stable LTO + PGO PR
  • s390x RHEL8 LTO PR
  • PPC64LE CentOS9 LTO + PGO PR
  • s390x Fedora LTO PR

@encukou
Copy link
Member

encukou commented Mar 4, 2024

(The posix.sched_setaffinity(0, []) on CentOS9 is unrelated, not a CPython issue.)

@markshannon
Copy link
Member

Is this ready to be merged?

@encukou encukou merged commit ea1b1c5 into python:main Mar 4, 2024
59 of 67 checks passed
@encukou
Copy link
Member

encukou commented Mar 4, 2024

Yes. Thank you @skirpichev for the quick fix!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…onGH-116302)

pythongh-108562: partial reversion of pr114751

Reverts -fstrict-overflow for libmpdec
@skirpichev skirpichev deleted the partial-revert-gh-108562 branch March 5, 2024 01:46
@skirpichev
Copy link
Member Author

Thanks. Sorry for a breakage. Next time I will suggest running more extended tests.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…onGH-116302)

pythongh-108562: partial reversion of pr114751

Reverts -fstrict-overflow for libmpdec
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…onGH-116302)

pythongh-108562: partial reversion of pr114751

Reverts -fstrict-overflow for libmpdec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants