-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/point cloud utils #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/2.0.0
Are you sure you want to change the base?
Conversation
|
I did not find 3D domain, but I think that by providing the possibility to give individual boundary coordinates, I am solving a problem that does not exist and no one asked for it, so I have remove it ! |
|
@eleniv3d I Believe this PR is ready for review ;) |
Yeah, i guess one would use the domain box for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some first comments. Let me know what you think :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the metadata doesn't match the current implementation.. inputs/outputs are different :)
I would also suggest a slight refactoring.. Since we are now outputting both the point clouds inside the box/brep, i would consider renaming the component to sth like DF Cloud Split
and then I think inputs could be:
- Cloud “The point cloud to split.”
- Boundary “Closed Box or Brep that defines the inside region.”
with outputs:
- Cloud Inside
- Cloud Outside
That would also mean that we check internally if its is a box or brep. it just feels a bit weird to me to have inputs that are not used between box and brep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and actually I noticed that if you feed in a non-axis-aligned bounbding box, it computes the axis aligned bb of that box, so there is some improvement there too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eleniv3d , I believed I answered to your comments. Sorry the metadata was quite sloppy. |
This PR concerns the addition of point cloud utilities to diffCheck: cropping, substraction (one PC - other PC by comparing the distances of their points using KDSearch)
Cropping:
This component crops a point cloud based on a bbox or boundary values (set a minimum value for z coordinate, for example
Using bbox:
Using boundary to coordinates:
Subtracting
This component removes points from a point cloud when they are too close to another point cloud