Add tests for case expressions #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannes-steffenhagen-diffblue
approved these changes
Mar 29, 2019
testsuite/gnat2goto/tests/case_expression_others/case_expression_others.adb
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1 @@ | |||
| ALL XFAIL CBMC crashes with first argument of if must be boolean, but got or | |||
There was a problem hiding this comment.
can you squash this together with the commit fixing this so you can remove it?
| begin | ||
| Result := (case Random_Val is | ||
| when 1..10 => 1, | ||
| when 11..20 => 2, |
There was a problem hiding this comment.
I suspect handling a range expression should be fairly easy - a literal range should always be translatable like this x in a..b ===> a <= x and x <= b I'd think
to avoid constant folding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the work performed for case statement support in gnat2goto (#171) it was discovered that we do support case expressions already, but it's not a documented nor tested feature. This adds some basic tests for this, and fixes any problems discovered.