Subprogram body stub #245
Merged
Subprogram body stub #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjj2017
force-pushed
the
subprogram_body_stub
branch
from
b0e9be1 to
b1a4866
Compare
tjj2017
force-pushed
the
subprogram_body_stub
branch
from
b1a4866 to
9d45d43
Compare
|
I have rebased this branch to diffblue/master |
xbauch
reviewed
Jun 13, 2019
xbauch
reviewed
Jun 13, 2019
xbauch
reviewed
Jun 13, 2019
tjj2017
force-pushed
the
subprogram_body_stub
branch
2 times, most recently
from
144e42f to
27bf078
Compare
|
I have rebased this on PR #220 as this fix is required for this branch. It passes the regression tests and I have updated the golden results |
|
Should that be rebased on to #256 ? |
tjj2017
force-pushed
the
subprogram_body_stub
branch
from
27bf078 to
d1483bb
Compare
The gnat front end ensures that the subunit corresponding to a body stub exists and checks it semantically.
tjj2017
force-pushed
the
subprogram_body_stub
branch
from
d1483bb to
2e5c86f
Compare
|
@martin-cs - yeah, it's been rebased on master now #256 has been merged. |
…n_results Update golden results
martin-cs
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UKNI has subprogram_body_stubs. The changes on this branch facilitate handling of these stubs by gnat2goto.
The test program which has been added to the regression tests for this new feature, P, has an assertion I think should succeed (if overflows are ignored), but it seems at the moment that the assertion fails. The action of the called subprogram, Inc, does not seem to be considered by cbmc.
Should I mark this with an XFAIL? If so I think I should have another test without the assertion so that the subprogram_body_stub feature is always tested.